Skip to content

translated /about/community.md page to Ukrainian#2199

Merged
6 commits merged intonodejs:masterfrom
alexandrtovmach:patch/translation-uk
Apr 24, 2019
Merged

translated /about/community.md page to Ukrainian#2199
6 commits merged intonodejs:masterfrom
alexandrtovmach:patch/translation-uk

Conversation

@alexandrtovmach
Copy link
Copy Markdown
Contributor

Help with the localization process:

  • translated /about/community.md page to Ukrainian

@ghost
Copy link
Copy Markdown

ghost commented Apr 20, 2019

@nodejs/nodejs-uk: Please have a review, thanks!

@alexandrtovmach
Copy link
Copy Markdown
Contributor Author

Thank you, but unfortunately it seems like stalled team, so I've created direct PR, and now working on other translations to Ukrainian and Russian

@ghost
Copy link
Copy Markdown

ghost commented Apr 20, 2019

@alexandrtovmach:For Russian version, if this is different from Ukrainian, you have to create a new locale by copying 'en' folder with all of its files, and then do translations for them(Maybe the language name will be 'ru'?)

The reason why I help you to notify your group is because some member (such as @vsemozhetbyt or someone else) will help you to have a review if he/she is free :)

So no worries about that, but still say a BIG THANK YOU to you for your first contribution!

Copy link
Copy Markdown
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Just some possible nits.

Comment thread locale/uk/about/community.md Outdated
Comment thread locale/uk/about/community.md Outdated
Comment thread locale/uk/about/community.md Outdated
Comment thread locale/uk/about/community.md Outdated
Comment thread locale/uk/about/community.md Outdated
Comment thread locale/uk/about/community.md Outdated
Comment thread locale/uk/about/community.md Outdated
Comment thread locale/uk/about/community.md Outdated
Comment thread locale/uk/about/community.md Outdated
Comment thread locale/uk/about/community.md Outdated
Co-Authored-By: alexandrtovmach <alexandrtovmach@gmail.com>
@alexandrtovmach
Copy link
Copy Markdown
Contributor Author

I'll apply it in a few days. Thanks for a help.

And thanks for notes about Russian translation, I'm doing in the same way. Thanks a lot

@ghost
Copy link
Copy Markdown

ghost commented Apr 21, 2019

@alexandrtovmach:Just a tip——The 'knowledge' and all the files in 'blog' you don't need to do any translations now.

@alexandrtovmach
Copy link
Copy Markdown
Contributor Author

Sure, thanks

vsemozhetbyt and others added 2 commits April 22, 2019 11:22
approve suggestion#1

Co-Authored-By: alexandrtovmach <alexandrtovmach@gmail.com>
@alexandrtovmach
Copy link
Copy Markdown
Contributor Author

applied @vsemozhetbyt notes

@ghost ghost requested a review from vsemozhetbyt April 22, 2019 09:25
Comment thread locale/uk/about/community.md Outdated
Comment thread locale/uk/about/community.md Outdated
vsemozhetbyt and others added 2 commits April 23, 2019 12:59
Co-Authored-By: alexandrtovmach <alexandrtovmach@gmail.com>
Co-Authored-By: alexandrtovmach <alexandrtovmach@gmail.com>
@ghost
Copy link
Copy Markdown

ghost commented Apr 24, 2019

@vsemozhetbyt:Can I merge this now?

@vsemozhetbyt
Copy link
Copy Markdown
Contributor

Yes, I think)

@ghost ghost merged commit 4c47e8b into nodejs:master Apr 24, 2019
@ghost
Copy link
Copy Markdown

ghost commented Apr 24, 2019

Thanks @alexandrtovmach and @vsemozhetbyt for your contributions!

@alexandrtovmach alexandrtovmach deleted the patch/translation-uk branch July 1, 2019 06:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants